Skip to content

Remove x64 exception handling code and support aarch64 - #562

Merged
syntactically merged 6 commits into
mainfrom
lm/aarch64
Nov 5, 2026
Merged

syntactically merged 6 commits into
mainfrom
lm/aarch64

Conversation

@syntactically

Copy link
Copy Markdown
Member

No description provided.

@syntactically syntactically added the kind/enhancement New feature or request label Oct 20, 2026
@syntactically
syntactically added this pull request to stack #563 October 20, 2026 00:42
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from f1bc9ae to 3975edd Compare October 20, 2026 00:56
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 5a2b052 to a43136d Compare October 20, 2026 17:24
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 8c0eed1 to f3e17b7 Compare October 20, 2026 19:08
This requires changing the wasi-sdk builder container
definition/script a little bit to make sure it works on aarch64 as
well as x86_64.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
syntactically force-pushed the lm/aarch64 branch 5 times, most recently from 87e2264 to 8ebab69 Compare October 21, 2026 19:29
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from d2c6ee7 to 5213f3b Compare October 22, 2026 14:45
jsturtevant
jsturtevant previously approved these changes Oct 23, 2026

@jsturtevant jsturtevant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like ci still needs some work but over all this LGTM

@syntactically
syntactically force-pushed the lm/aarch64 branch 11 times, most recently from 04ca0f6 to a3181ae Compare November 2, 2026 17:47
@syntactically
syntactically force-pushed the lm/aarch64 branch 4 times, most recently from b2f884a to e41caf1 Compare November 4, 2026 17:32
jsturtevant
jsturtevant previously approved these changes Nov 4, 2026

@ludfjig ludfjig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but ai had some comments

Comment thread .github/workflows/dep_rust.yml Resolved
Comment thread Justfile Resolved
As of Hyperlight 0.18.0, all of the functionality we need is
supported(ish) with architecture-independent interfaces in core
Hyperlight. Remove the old architecture-specific code in favour of
those new interfaces.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Not all guests are x64 anymore.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
syntactically merged commit 0142e42 into main Nov 5, 2026
325 of 339 checks passed
@syntactically
syntactically deleted the lm/aarch64 branch November 5, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants